Revert Setup Settings constant before the database is connected #23038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit agrare@a4b57ee with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
@jrafanie Please be aware this will re-break Rails 7, so we need to fix a different way. |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
May 20, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
May 29, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 3, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 5, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 19, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 21, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jul 11, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jul 12, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jul 18, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jul 18, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038.
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jul 18, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038. High level: We have plugins that expect the `Settings` constant to be defined. These will have to use the defaults from the filesystem as we don't have access to the database this early. We can then use a rails 7 friendly location to start autoloading, the after_initialize. Using the test from ManageIQ#23038, I was able to verify this on the rails7 branch and on master with rails 6.1: ``` joerafaniello@Joes-MBP manageiq % bin/rails c Loading development environment (Rails 6.1.7.8) irb(main):001:0> SettingsChange.first => nil irb(main):002:0> Settings.log.level => "info" irb(main):003:0> Settings.log.level = "debug" => "debug" irb(main):004:0> Vmdb::Settings.save!(MiqServer.my_server, Settings.to_h) => [] irb(main):005:0> Settings.log.level => "debug" irb(main):006:0> SettingsChange.first => #<SettingsChange:0x00000001183e5648 id: 99000000000005, resource_type: "MiqServer", resource_id: 99000000000002, key: "/log/level", value: "debug", created_at: Thu, 18 Jul 2024 19:15:50.513221000 UTC +00:00, updated_at: Thu, 18 Jul 2024 19:15:50.513221000 UTC +00:00> irb(main):007:0> exit joerafaniello@Joes-MBP manageiq % bin/rails c Loading development environment (Rails 6.1.7.8) irb(main):001:0> Settings.log.level => "debug" ```
1 task
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jul 18, 2024
This is an attempt to reimplement ManageIQ#22853 since that was reverted in ManageIQ#23038. High level: We have plugins that expect the `Settings` constant to be defined. These will have to use the defaults from the filesystem as we don't have access to the database this early. We can then use a rails 7 friendly location to start autoloading, the after_initialize. Using the test from ManageIQ#23038, I was able to verify this on the rails7 branch and on master with rails 6.1: ``` joerafaniello@Joes-MBP manageiq % bin/rails c Loading development environment (Rails 6.1.7.8) irb(main):001:0> SettingsChange.first => nil irb(main):002:0> Settings.log.level => "info" irb(main):003:0> Settings.log.level = "debug" => "debug" irb(main):004:0> Vmdb::Settings.save!(MiqServer.my_server, Settings.to_h) => [] irb(main):005:0> Settings.log.level => "debug" irb(main):006:0> SettingsChange.first => #<SettingsChange:0x00000001183e5648 id: 99000000000005, resource_type: "MiqServer", resource_id: 99000000000002, key: "/log/level", value: "debug", created_at: Thu, 18 Jul 2024 19:15:50.513221000 UTC +00:00, updated_at: Thu, 18 Jul 2024 19:15:50.513221000 UTC +00:00> irb(main):007:0> exit joerafaniello@Joes-MBP manageiq % bin/rails c Loading development environment (Rails 6.1.7.8) irb(main):001:0> Settings.log.level => "debug" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #22853 since it caused Settings to not load SettingsChanges
Before:
After: