Use a matrix for test-repos not jobs #579
Conversation
| "uses" => "ManageIQ/manageiq-cross_repo/.github/workflows/manageiq_cross_repo.yaml@master", | ||
| "with" => { | ||
| "test-repo" => test_repo, | ||
| "test-repo" => "[#{test_repos.map { |repo| "\"#{repo}\"" }.join(", ")}]", |
There was a problem hiding this comment.
| "test-repo" => "[#{test_repos.map { |repo| "\"#{repo}\"" }.join(", ")}]", | |
| "test-repo" => test_repos.inspect, |
Ruby array syntax is JSON compliant, so this is a lot simpler.
There was a problem hiding this comment.
Ah thanks much better, felt like there had to be a better way to do that 😆
agrare
force-pushed
the
update_github_actions_matrix
branch
from
d8f26d7
to
598ff45
Compare
|
Checked commits agrare/miq_bot@598ff45~...341e80d with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
| "test-repo" => test_repo, | ||
| "repos" => repos.join(",") | ||
| "test-repos" => test_repos.inspect, | ||
| "repos" => repos.join(",") |
There was a problem hiding this comment.
Not for this PR, but it might be nice to do this one as repos.inspect for consistency with test-repos. I know that it's not used in the same way, but it's weird to have one be an "Array" and the other not.
There was a problem hiding this comment.
Yeah it is because this one is passed as an env var where the other is split into individual repos but don't disagree
There is a limit of 20 on the number of times other workflows can be referenced in a workflow, so rather than 1 job per repo use a matrix for test-repo