Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't strip :root pseudo-class #173

Merged
merged 4 commits into from
Feb 8, 2024
Merged

fix: don't strip :root pseudo-class #173

merged 4 commits into from
Feb 8, 2024

Conversation

asgerb
Copy link
Contributor

@asgerb asgerb commented Feb 6, 2024

This PR adds the :root pseudo-class to BAD_PSEUDO_FUNCTIONS, so it doesn't get stripped from the output CSS.

I've needed this to retain custom properties defined for my stylesheets.

@asgerb asgerb changed the title fix: don't strip root pseudo-class fix: don't strip :root pseudo-class Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cea4110) 97.84% compared to head (ae77e8a) 97.85%.

❗ Current head ae77e8a differs from pull request most recent head 7189178. Consider uploading reports for the commit 7189178 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   97.84%   97.85%           
=======================================
  Files          57       57           
  Lines        1994     2002    +8     
=======================================
+ Hits         1951     1959    +8     
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mange
Copy link
Owner

Mange commented Feb 6, 2024

Looks really great! Thank you for your contribution! ❤️

Would you mind adding yourself to the Changelog under the "dev" heading as part of this PR? You can credit yourself how you want your name to appear. You can look at the other examples in the file to get an idea on how to do it.

@asgerb
Copy link
Contributor Author

asgerb commented Feb 7, 2024

Certainly, just added it now 🙂

@Mange Mange merged commit f87292a into Mange:master Feb 8, 2024
5 of 6 checks passed
@Mange
Copy link
Owner

Mange commented Feb 8, 2024

Version 5.2.1 was just released with this fix included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants