Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify with in-tree compiletest-rs #238

Open
1 task
Manishearth opened this issue Mar 9, 2021 · 7 comments
Open
1 task

Unify with in-tree compiletest-rs #238

Manishearth opened this issue Mar 9, 2021 · 7 comments

Comments

@Manishearth
Copy link
Owner

I'd like for us to eventually have a world where rustc simply depends on compiletest-rs, and compiletest-rs lives in rust-lang

Blockers:

@Munksgaard
Copy link
Collaborator

I sorta-kinda tried to address this in #201, but never got around to finishing it. My impression was that rustc had some exotic requirements for its internal compiletest that were hard to generalise for this package.

I don't expect I'll get back to working on that PR anytime soon, and it's probably diverged too far from upstream by now to be of any real use, but it is there, if anyone wants to take a look.

@Manishearth
Copy link
Owner Author

Yeah I'm wondering if we can keep those requirements but perhaps behind a flag.

@Manishearth
Copy link
Owner Author

I really don't want us to have to maintain this as a fork 😄

@Manishearth
Copy link
Owner Author

Instead of doing a merge, we could potentially try a "fresh start" where we first try moving compiletest out of tree, and if that works, release it as a breaking version bump to this crate, making sure major users (clippy, syn) have everything they need to upgrade.

@Munksgaard
Copy link
Collaborator

I really don't want us to have to maintain this as a fork smile

Yeah, we should try to minimize the maintenance burden as much as possible.

@Munksgaard
Copy link
Collaborator

Instead of doing a merge, we could potentially try a "fresh start" where we first try moving compiletest out of tree, and if that works, release it as a breaking version bump to this crate, making sure major users (clippy, syn) have everything they need to upgrade.

That may not be a bad idea. At least, it's worth a shot :-)

@Manishearth
Copy link
Owner Author

Filed rustc side of this issue in rust-lang/rust#82946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants