From 39139b75360d314d83326550c5746bd2b9832f4d Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Wed, 13 Dec 2023 16:52:38 -0800 Subject: [PATCH] Make fraction and num-bigint an optional dep of datagen (#4458) --- provider/datagen/Cargo.toml | 6 +++--- tools/depcheck/src/allowlist.rs | 5 ----- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/provider/datagen/Cargo.toml b/provider/datagen/Cargo.toml index 3b4ee540873..b483a321448 100644 --- a/provider/datagen/Cargo.toml +++ b/provider/datagen/Cargo.toml @@ -88,8 +88,8 @@ zip = { version = ">=0.5, <0.7", default-features = false, features = ["deflate" rayon = { version = "1.5", optional = true } ureq = { version = "2", optional = true } -fraction = {version = "0.14.0", default-features = false } -num-bigint = { version = "0.4.4", default-features = false } +fraction = { version = "0.14.0", default-features = false, optional = true } +num-bigint = { version = "0.4.4", default-features = false, optional = true } # Dependencies for "bin" feature @@ -130,7 +130,7 @@ icu_compactdecimal = ["dep:icu_compactdecimal"] icu_displaynames = ["dep:icu_displaynames"] icu_relativetime = ["dep:icu_relativetime"] icu_transliterate = ["dep:icu_transliterate"] -icu_unitsconversion = ["dep:icu_unitsconversion"] +icu_unitsconversion = ["dep:icu_unitsconversion", "dep:fraction", "dep:num-bigint"] experimental_components = [ "icu_compactdecimal", "icu_displaynames", diff --git a/tools/depcheck/src/allowlist.rs b/tools/depcheck/src/allowlist.rs index 83889a6fb30..08d3a4dda6b 100644 --- a/tools/depcheck/src/allowlist.rs +++ b/tools/depcheck/src/allowlist.rs @@ -142,18 +142,13 @@ pub const EXTRA_DATAGEN_DEPS: &[&str] = &[ "databake-derive", "elsa", "erased-serde", - "fraction", "icu_codepointtrie_builder", "itertools", "itoa", "matrixmultiply", "ndarray", - "num", - "num-bigint", "num-complex", "num-integer", - "num-iter", - "num-rational", "num-traits", "once_cell", "rawpointer",