From 7eb1f65e3a62530101cb5c6955733f72fa0dfd82 Mon Sep 17 00:00:00 2001 From: Peter Rushforth Date: Wed, 18 Dec 2024 16:47:21 -0500 Subject: [PATCH] Clean up map-layer _registerMediaQuery --- src/layer.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/layer.js b/src/layer.js index c04a2d714..defa1932b 100644 --- a/src/layer.js +++ b/src/layer.js @@ -132,11 +132,9 @@ export class BaseLayerElement extends HTMLElement { } _registerMediaQuery(mq) { if (!this._changeHandler) { - // Define and bind the change handler once this._changeHandler = () => { this._onRemove(); if (this._mql.matches) { - // TODO evaluate if _onAdd does the right thing for this situation this._onAdd(); } // set the disabled 'read-only' attribute indirectly, via _validateDisabled @@ -154,13 +152,11 @@ export class BaseLayerElement extends HTMLElement { this._mql.removeEventListener('change', this._changeHandler); } - // Set up the new media query and listener this._mql = map.matchMedia(mq); - this._changeHandler(); // Initial evaluation + this._changeHandler(); this._mql.addEventListener('change', this._changeHandler); } else if (this._mql) { // the media attribute removed or query set to '' - // Clean up the existing listener this._mql.removeEventListener('change', this._changeHandler); delete this._mql; // effectively, no / empty media attribute matches, do what changeHandler does