Fix segfault in test

Fail test suite if child process receives a signal. Fixes segfault in test. PR-URL: nodejs/node-addon-api#148 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas · Oct 25, 2017 · e2a5de5 · e2a5de5
1 parent 65c020b
commit e2a5de5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/test/index.js b/test/index.js
@@ -28,5 +28,11 @@ if (typeof global.gc === 'function') {
   const child = require('./napi_child').spawnSync(process.argv[0], [ '--expose-gc', __filename ], {
     stdio: 'inherit',
   });
-  process.exitCode = child.status;
+
+  if (child.signal) {
+    console.log(`Tests aborted with ${child.signal}`);
+    process.exitCode = 1;
+  } else {
+    process.exitCode = child.status;
+  }
 }
diff --git a/test/objectwrap.cc b/test/objectwrap.cc
@@ -14,6 +14,8 @@ class TestIter : public Napi::ObjectWrap<TestIter> {
     Constructor = Napi::Persistent(DefineClass(env, "TestIter", {
       InstanceMethod("next", &TestIter::Next),
     }));
+
+    Constructor.SuppressDestruct();
   }
 
   static Napi::FunctionReference Constructor;