Move vitepress to devDependencies, bump it to official v1.x.x release #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Side note: Also not sure if |
|
Thanks a lot! I'm checking the deploy preview and it looks all right 👍
Ahh, judging by the number of lines changed ( Probably should be exactly the same as here: https://github.com/vitejs/vite/blob/main/.gitignore#L9 |
|
Let me update the PR then ;) |
|
Looks great, thanks a lot 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104, also bumps Vitepress since it was still using a
rcversion.I'm not a Vitepress expert by any means, but the only difference I could spot was a slightly larger top margin on the pages? Vitepress changelog notes two (unrelated) breaking changes since the formerly used release