From 30ba574b7958d81d028d75fb269bc23100e288b0 Mon Sep 17 00:00:00 2001
From: lkunjumon <lkunjumon@marvell.com>
Date: Wed, 3 Feb 2021 16:05:50 +0530
Subject: [PATCH 1/2] fix LGTM Issues

---
 device/delta/arm64-delta_tg48m_poe-r0/plugins/led_control.py | 5 -----
 device/delta/arm64-delta_tg48m_poe-r0/plugins/psuutil.py     | 2 --
 device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py     | 4 ----
 3 files changed, 11 deletions(-)

diff --git a/device/delta/arm64-delta_tg48m_poe-r0/plugins/led_control.py b/device/delta/arm64-delta_tg48m_poe-r0/plugins/led_control.py
index cb781877b..c8e9bbd75 100644
--- a/device/delta/arm64-delta_tg48m_poe-r0/plugins/led_control.py
+++ b/device/delta/arm64-delta_tg48m_poe-r0/plugins/led_control.py
@@ -7,11 +7,6 @@
 #
 try:
     from sonic_led.led_control_base import LedControlBase
-    import swsssdk
-    import threading
-    import os
-    import logging
-    import struct
     import time
     from socket import *
     from select import *
diff --git a/device/delta/arm64-delta_tg48m_poe-r0/plugins/psuutil.py b/device/delta/arm64-delta_tg48m_poe-r0/plugins/psuutil.py
index 17012263c..faf1b90ed 100755
--- a/device/delta/arm64-delta_tg48m_poe-r0/plugins/psuutil.py
+++ b/device/delta/arm64-delta_tg48m_poe-r0/plugins/psuutil.py
@@ -1,7 +1,6 @@
 #!/usr/bin/env python
 
 import sys
-import os.path
 if sys.version_info[0] < 3:
     import commands as cmd
 else:
@@ -23,7 +22,6 @@ class PsuUtil(PsuBase):
 
     def __init__(self):
        PsuBase.__init__(self)
-       MAX_PSUS = 2
 
     def get_num_psus(self):
         MAX_PSUS = 2
diff --git a/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py b/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py
index b5cb80db2..57a1b08ec 100755
--- a/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py
+++ b/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py
@@ -107,8 +107,6 @@ def get_presence(self, port_num):
             return False
         prt = port_num % 49
         sel = "{0:02b}".format(prt)
-        p = sel[0]
-        q = sel[1]
 
         pos = [1,2,4,8]
         bit_pos = pos[prt]
@@ -232,7 +230,6 @@ def port_to_eeprom_mapping(self):
 
     def get_transceiver_change_event(self, timeout):
         port_dict = {}
-        port = 0
 
         if timeout == 0:
             cd_ms = sys.maxint
@@ -264,7 +261,6 @@ def get_transceiver_change_event(self, timeout):
             return True, port_dict
         else:
             return True, {}
-        return False, {}
 
 
 

From 72714a7e8c4634a0c5befe63d4085b84851f2f78 Mon Sep 17 00:00:00 2001
From: lkunjumon <lkunjumon@marvell.com>
Date: Thu, 4 Feb 2021 09:30:58 +0530
Subject: [PATCH 2/2] Adding lgtm fix

---
 device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py b/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py
index 57a1b08ec..77e37112c 100755
--- a/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py
+++ b/device/delta/arm64-delta_tg48m_poe-r0/plugins/sfputil.py
@@ -106,17 +106,17 @@ def get_presence(self, port_num):
         if port_num < self._port_start or port_num > self._port_end:
             return False
         prt = port_num % 49
-        sel = "{0:02b}".format(prt)
+        #sel = "{0:02b}".format(prt)
 
         pos = [1,2,4,8]
         bit_pos = pos[prt]
         if smbus_present == 0:
-             cmdstatus, sfpstatus = cmd.getstatusoutput('i2cget -y 2 0x41 0x3') #need to verify the cpld register logic
+             cmdstatus, sfpstatus = cmd.getstatusoutput('i2cget -y 2 0x41 0x3A') #need to verify the cpld register logic
              sfpstatus = int(sfpstatus, 16)
         else :
              bus = smbus.SMBus(2)
              DEVICE_ADDRESS = 0x41
-             DEVICE_REG = 0x3
+             DEVICE_REG = 0x3A
              sfpstatus = bus.read_byte_data(DEVICE_ADDRESS, DEVICE_REG)
         sfpstatus = sfpstatus&(bit_pos)
         if sfpstatus == 0: