Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Visual Studio 2019 #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheZoc
Copy link

@TheZoc TheZoc commented Jan 31, 2021

This PR will allow the user to compile mdloader for Windows easily, using Visual Studio 2019.
(It probably works in Visual Studio 2017, but I don't have it installed right now).

I used the superb getopt windows implementation by Ludvik Jerabek, as it is LGPL and works as the perfect drop in replacement for linux implementation.

@TheZoc
Copy link
Author

TheZoc commented Oct 5, 2021

  • Rebased and fixed conflicts

@zvecr
Copy link
Collaborator

zvecr commented Oct 6, 2021

It should be noted that the project builds fine within MSYS2 (and the QMK MSYS bundle) so there is a small trade-off on maintainability, having to keep the 2 build systems in step.

I would be tempted to implement this more like this, swapping to cmake as to not introduce as many VS specific changes.

@TheZoc
Copy link
Author

TheZoc commented Oct 7, 2021

I personally don't like cmake for a bunch of reasons, not to mention it's an overkill for a project this size.
On Windows, it will just be a hard to use wrapper around Microsoft tools.

By looking at the comparison you linked, that one just look like a rework of another PR again - you just added the same solution I added and replaced the visual studio project files with cmake.

As long as the getopt is there, it's easy to re-create the project in visual studio. It's a plain project with all the files added.

--

I'll refrain from commenting or contributing from now on: clearly our views are different on this project and I'm not the one being paid to maintain it. Good luck.

@zvecr
Copy link
Collaborator

zvecr commented Oct 7, 2021

By looking at the comparison you linked, that one just look like a rework of another PR again - you just added the same solution I added and replaced the visual studio project files with cmake.

How else would you show a comparison of an alternative solution? I locally applied your changes and went from there. I had no intentions on PRing it, and was just using the branch to better explain the changes. Such as the extra parent folder to getopt, so it doesnt dirty the unix include path, and the less error prone memset alternative. Visual studio has supported cmake projects for a while, so it doesnt seem like it adds that much overhead in the context of adding VS2019 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants