Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved linux behaviours #548

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Improved linux behaviours #548

merged 4 commits into from
Sep 22, 2023

Conversation

therealryan
Copy link
Contributor

@therealryan therealryan commented Sep 22, 2023

Resolves #444 : I'm not super-thrilled about this change, but it's an improvement on previous behaviour.

Resolves #455 : I don't quite have the mana to add platform-specific code for something missing from the JRE that should just work by default. I'll settle for no longer throwing an exception.

While we're here, we've:

  • Removed more repetitive groupId values
  • Fixed a test failure that'll pop up when we move to a later JRE - we shouldn't really be testing the message of an exception thrown by the JRE
  • Removed an unused import
  • Automated refactor: simplified a while loop

@therealryan therealryan changed the title improved file read failure mode Improved linux behaviours Sep 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@therealryan therealryan merged commit e9344c1 into main Sep 22, 2023
10 checks passed
@therealryan therealryan deleted the linux_bad_file_read branch September 22, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve linux desktop integration Fix ReaderTest.badReadLinux
1 participant