Skip to content

Conversation

@SangJunBak
Copy link
Contributor

It'd be nice to point it at the recent mz version tag, but unfortunately we'd need to wait for another release. For now just pointing it at main

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@SangJunBak SangJunBak requested a review from a team as a code owner November 19, 2025 18:30
@SangJunBak SangJunBak requested a review from kay-kim November 19, 2025 18:30
Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops ... just noticed your step doesn't work.

@@ -0,0 +1,4 @@
```shell
curl -o prometheus_scrape_configs.yml
https://raw.githubusercontent.com/MaterializeInc/materialize/refs/heads/main/doc/user/data/self_managed/monitoring/prometheus.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This renders as two lines ... so, user will get:
curl: (2) no URL specified

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch! Fixed

@SangJunBak SangJunBak force-pushed the jun/move-prom-config-to-main branch from 6feaa84 to 8f3ebce Compare November 19, 2025 19:51
@SangJunBak SangJunBak enabled auto-merge (squash) November 19, 2025 19:53
@SangJunBak SangJunBak merged commit 237942b into MaterializeInc:main Nov 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants