Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix build on M1 macs #5705

Closed

Conversation

cormacrelf
Copy link

@cormacrelf cormacrelf commented Feb 10, 2021

Materialize doesn't currently build on M1. This is basically due to outdated build deps not passing the arch correctly when compiling certain dependencies, you know, that sort of thing. I've updated a couple of them here and it's at least a bit closer.

There is one remaining issue that I can see, and it is rdkafka-sys, which fails to link the built librdkafka library because Cargo is not yet capable of linking to Mach-O universal binaries. It fails with an error: failed to add native library ... librdkafka.a: file too small to be an archive message.

There is a cargo issue here rust-lang/cargo#8875

For now, I'll leave this as a draft so at least people can see where it's at / google for why.


This change is Reviewable

cargo update -p cc -p cmake -p openssl-src
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2021

CLA assistant check
All committers have signed the CLA.

@benesch
Copy link
Member

benesch commented Feb 10, 2021

Thanks! Don't hesitate to ping if this becomes ready to merge.

@benesch
Copy link
Member

benesch commented Mar 2, 2021

We have a report that #5916 fixed compilation on M1 macs, so gonna close this out. Thanks for the initial work! If for some reason you still have build troubles, definitely give us a shout.

@benesch benesch closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants