Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Materialize doesn't currently build on M1. This is basically due to outdated build deps not passing the arch correctly when compiling certain dependencies, you know, that sort of thing. I've updated a couple of them here and it's at least a bit closer.
There is one remaining issue that I can see, and it is rdkafka-sys, which fails to link the built librdkafka library because Cargo is not yet capable of linking to Mach-O universal binaries. It fails with an
error: failed to add native library ... librdkafka.a: file too small to be an archive
message.There is a cargo issue here rust-lang/cargo#8875
For now, I'll leave this as a draft so at least people can see where it's at / google for why.
This change is