This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Add PCM & FLAC as standard audio encoder options for capturing lossless audio #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...audio losslessly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "PCM" & "FLAC" options to audio encoder list for custom codecs. PCM & FLAC are both lossless formats.
Please look over my changes carefully as I currently do not have a C# compiler so I cannot test it
Related issue: #378
Edit: I'm not sure if it would be safer to use "pcm_s16le" instead of "copy" for PCM encoder. On my system pcm_s16le is the native format, so "copy" saves in that format without having to do any re-encoding. I assume that all Windows systems use pcm_s16le natively, but I could be wrong.