EbmlString/UTFstring/EbmlUnicodeString: automatic memory management #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbunkus
added
api-break
|
Inspired by #111. |
|
Gnarf… I'll fix those. I thought |
mbunkus
force-pushed
the
string-wstring-automatic-memory-management
branch
from
2cf128d
to
33ed443
Compare
|
Fixed. |
neheb
reviewed
Dec 22, 2023
|
Very nice overall. |
neheb
approved these changes
Dec 22, 2023
neheb
reviewed
Dec 23, 2023
neheb
reviewed
Dec 23, 2023
robUx4
approved these changes
Dec 23, 2023
|
We may add some tests to test before and after usage and conversion. |
robUx4
reviewed
Dec 23, 2023
|
Merging as all the points mentioned by @neheb have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.