Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable building DLL on Windows #187

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Disable building DLL on Windows #187

merged 2 commits into from
Dec 28, 2023

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Dec 28, 2023

And build dynamic libraries in the Linux CI.

@robUx4 robUx4 added api-break breaks the API (e.g. programs using it will have to adjust their source code) abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) labels Dec 28, 2023
@robUx4
Copy link
Contributor Author

robUx4 commented Dec 28, 2023

It turns out ebml_export.h is needed on Linux (and macOS). It's using __attribute__((visibility("default"))).

@robUx4 robUx4 force-pushed the no_dll branch 2 times, most recently from 5c82e80 to ca2b41f Compare December 28, 2023 09:05
@robUx4 robUx4 mentioned this pull request Dec 28, 2023
Merged
@robUx4 robUx4 merged commit 74b6bb2 into Matroska-Org:master Dec 28, 2023
14 checks passed
@robUx4 robUx4 deleted the no_dll branch December 28, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus