Rework element creation #289
Open
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
api-break
robUx4
force-pushed
the
create_semantic
branch
2 times, most recently
from
8dddf21
to
0b334d4
Compare
In all cases we were creating an element with the empty constructor. This is available via the EbmlCallbacks.
We don't need a specific function for that.
EBML_SEM_CREATE should be used instead
i.e. it EbmlCallbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To create a bare EbmlElement we don't need an actual element as in CreateElement(). We just need an EbmlCallbacks which may or may not come from an element.
For now
CreateElement()is kept for backward compatibility but it can be replaced by anEBML_CREATE()call, which can callCreateElement()when compiled with libebml 1.x.