Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.2.2 support #17

Closed
mmso opened this issue Feb 24, 2021 · 3 comments · Fixed by #20
Closed

Typescript 4.2.2 support #17

mmso opened this issue Feb 24, 2021 · 3 comments · Fixed by #20
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mmso
Copy link

mmso commented Feb 24, 2021

With the latest dom definitions in TypeScript, some types have been removed such as UnderlyingByteSource, ReadableStreamBYOBReader, or ReadableByteStreamController microsoft/TypeScript#42067

This causes a compilation error if library checking is enabled.

@MattiasBuelens
Copy link
Owner

Riiight, I had updated the Stream DOM types a while back in microsoft/TypeScript-DOM-lib-generator#890, and kind of forgot about it. But now that TypeScript 4.2 is out, those new types have landed as well. So I'm breaking my own projects again. 😅

I'll have a look.

@MattiasBuelens MattiasBuelens added the bug Something isn't working label Feb 24, 2021
@MattiasBuelens MattiasBuelens self-assigned this Feb 24, 2021
@lgrahl
Copy link

lgrahl commented May 10, 2021

Hoping a polite ping is appropriate and many thanks for this project. 🙂

@MattiasBuelens
Copy link
Owner

Found some time to finish this up. Published as v0.1.0. 🙂

Note that, although the "alpha" status is now gone, this is still very much a v0.x project. But at least it's somewhat usable already. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants