lib: make console writable and non-enumerable

According to the standard the property descriptor of console should be writable and non-enumerable. PR-URL: nodejs#17708 Fixes: nodejs#11805 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MayaLekova · May 8, 2018 · 0c1fef4 · 0c1fef4
1 parent 395ffe3
commit 0c1fef4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/internal/bootstrap_node.js b/lib/internal/bootstrap_node.js
@@ -321,10 +321,8 @@
     const wrappedConsole = NativeModule.require('console');
     Object.defineProperty(global, 'console', {
       configurable: true,
-      enumerable: true,
-      get() {
-        return wrappedConsole;
-      }
+      enumerable: false,
+      value: wrappedConsole
     });
     setupInspector(originalConsole, wrappedConsole, Module);
   }

diff --git a/test/message/console_low_stack_space.js b/test/message/console_low_stack_space.js
@@ -16,7 +16,7 @@ function a() {
   try {
     return a();
   } catch (e) {
-    compiledConsole = consoleDescriptor.get();
+    compiledConsole = consoleDescriptor.value;
     if (compiledConsole.log) {
       // Using `console.log` itself might not succeed yet, but the code for it
       // has been compiled.