Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS13 code does not correctly call time function #7655

Closed
Taowyoo opened this issue May 25, 2023 · 0 comments · Fixed by #7639
Closed

TLS13 code does not correctly call time function #7655

Taowyoo opened this issue May 25, 2023 · 0 comments · Fixed by #7639
Labels
bug component-tls size-s Estimated task size: small (~2d)

Comments

@Taowyoo
Copy link
Contributor

Taowyoo commented May 25, 2023

Summary

In:

#if defined(MBEDTLS_HAVE_TIME)
ssl->session_negotiate->start = time(NULL);
#endif /* MBEDTLS_HAVE_TIME */

#if defined(MBEDTLS_HAVE_TIME)
ssl->session_negotiate->start = time(NULL);
#endif /* MBEDTLS_HAVE_TIME */

Code need to call mbedtls_time to correctly handle the case if MBEDTLS_PLATFORM_TIME_MACRO is defined`

PR has been created for fixing this: #7639

System information

Mbed TLS version (3.4.0):
Operating system and version: Linux 5.15.0-72-generic #79~20.04.1-Ubuntu SMP Thu Apr 20 22:12:07 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Configuration (if not default, please attach mbedtls_config.h):
Compiler and options (if you used a pre-built binary, please indicate how you obtained it):
Additional environment information:

Expected behavior

Actual behavior

Steps to reproduce

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component-tls size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants