3.6 only: document f_rng callbacks #10182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
In public functions that take `f_rng, p_rng` callbacks, link to the documentation of the callback which is attached to the type name `mbedtls_f_rng_t`. Resolves Mbed-TLS#5868. ``` grep -l -w 'f_rng)' include | xargs perl -i -pe 's/\Qint (*f_rng)(void *, unsigned char *, size_t)\E/mbedtls_f_rng_t *f_rng/g' ``` and include `platform_util.h` where needed. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
needs-review
github-project-automation
bot
moved this to In Development
in Non-roadmap pull requests
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Since Mbed TLS 3.0, blinding is no longer optional in ECDSA. `mbedtls_ecdsa_write_signature()` and `mbedtls_ecdsa_write_signature_restartable()` error out if `f_rng == NULL`. We forgot to update the function documentation. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
bjwtaylor
approved these changes
Jun 3, 2025
github-project-automation
bot
moved this from In Development
to Has Approval
in Non-roadmap pull requests
gilles-peskine-arm
added
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Non-roadmap pull requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the RNG callbacks passed to legacy crypto and functions that call legacy crypto. Resolves #5868.
PR checklist