Remove \intval around MAX_IMAGE_BYTES in src/Service/SettingsManager.php, breaks settings name resolution
#1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
bug
ghost
self-assigned this
ghost
changed the title
\intval from MAX_IMAGE_BYTES, breaks name resolution\intval around MAX_IMAGE_BYTES in src/Service/SettingsManager.php, breaks settings name resolution
ghost
enabled auto-merge (squash)
|
Why is intval breaking it though? |
|
I guess intval never returns null and therefore the default is not kicking in? |
BentiGorlich
approved these changes
Aug 9, 2024
must be, Xdebug was showing 0 value assignment... |
|
I mean it is obviously not necessary if you don't get a type error... |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image uploads are currently broken, introduced by #997. PR removes it, settings can still be saved in settings page of admin panel.
Mentioned in #780 (comment) and confirmed in dev.