Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Protomechs Missing Map Art #1514

Closed
Xeno426 opened this issue Oct 14, 2019 · 1 comment
Closed

Some Protomechs Missing Map Art #1514

Xeno426 opened this issue Oct 14, 2019 · 1 comment
Assignees
@HammerGS
Labels
Data Hammertime.

Comments

@Xeno426
Copy link

Xeno426 commented Oct 14, 2019 •
edited
Loading

Environment

0.47.0
Platform Windows 7 6.1 (x86)
Java Version 8 update 221

Description

All the ultraheavy protomechs with the name "Ultraheavy Protomech" in their name use the default (Roc) map image, since the mechset.txt file has an entry only for the base unit name.
i.e. the mechset.txt has an entry for "Boggart", but the protomech's name in MM is "Boggart Ultraheavy Protomech".

This holds for the Boggart, Svartalfa, and Hobgoblin.

On a related issue, the quad Basilisk has a map image, but mechset.txt lists a unit by the name of "Basilisk (Quad)" while the actual MM file is named "Basilisk ProtoMech (Quad)". It's interesting to note that the Quad Basilisk is the only non-Ultraheavy protomech to have "Protomech" in its name. The entry is also for an "exact" match, so the "Basilisk ProtoMech (Quad) B" would still not get map art.

Curiously, the Sprite is the only Ultraheavy protomech to not have "Ultraheavy Protomech" in its name.

Files

boggart map icon
@HammerGS HammerGS self-assigned this Oct 14, 2019
@HammerGS HammerGS added the Data Hammertime. label Oct 14, 2019
HammerGS added a commit that referenced this issue Nov 6, 2019
@HammerGS
+ Issue #1514: Some Protomechs Missing Map Art
1265c6d
@HammerGS
Copy link
Member

HammerGS commented Nov 6, 2019

Fixed in 1265c6d

@HammerGS HammerGS closed this as completed Nov 6, 2019
neoancient pushed a commit that referenced this issue Jan 17, 2020
@HammerGS @neoancient
+ Issue #1514: Some Protomechs Missing Map Art
962e389 
(cherry picked from commit 1265c6d)
HammerGS added a commit to SJuliez/megamek that referenced this issue May 25, 2024
@HammerGS
Merging PR's
494ca0d 
MegaMek
+ Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively

MegaMekLab
+ Fix #MegaMek#1514: Fix Atrocious table shading render speed

MekHQ
+ PR MegaMek#4106: Use tabs in customize scenario dialog
+ PR MegaMek#4105: Updated Post-Scenario Logging for Prisoners
+ PR MegaMek#4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards
+ PR MegaMek#4102: Fixed Award Tier Count Calculations in PersonViewPanel
+ PR MegaMek#4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel
+ PR MegaMek#4054: Added Life Paths Campaign Options Tab, Added Education Module
            Very Important to read the documentation on this feature (See Docs folder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HammerGS HammerGS

Labels
Data Hammertime.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xeno426 @HammerGS