Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[49.8 Testing Branch] Bug or RFE? Confusing Infantry/BA damage message. #3654

Closed
Thom293 opened this issue May 25, 2022 · 2 comments · Fixed by #4647
Closed

[49.8 Testing Branch] Bug or RFE? Confusing Infantry/BA damage message. #3654

Thom293 opened this issue May 25, 2022 · 2 comments · Fixed by #4647
Labels
Bug GUI User Interface Reports Anything relating in game reporting

Comments

@Thom293
Copy link
Contributor

Thom293 commented May 25, 2022

21:05:30,385 INFO [megamek.MegaMek] {main}
megamek.MegaMek.initializeLogging(MegaMek.java:115) - Starting MegaMek v0.49.8-SNAPSHOT
Build Date: 2022-05-16T01:41:50.033873500
Release Date: 2022-02-18
Today: 2022-05-24
Origin Project: MekHQ
Java Vendor: AdoptOpenJDK
Java Version: 11.0.10
Platform: Windows 10 10.0 (amd64)
System Locale: en_US
Total memory available to MegaMek: 2 GB

I dont know if this is version specific or just always like this. I rarely use infantry or BA so its new to me regardless.

Basically, the damage output for BA (or perhaps anything) vs. Infantry is confusing. I will post a couple of screens as examples below.
It seemed like a bug to me at first but Mishra talked me through it and we both referenced TW and it appears the calculation may be correct, but we both agreed that how it is presented is very confusing. Its confusing, at least to me the user, because:

  1. The damage calculation is hidden. Here, in the example, it just shows "damage changed from 2 to 6" and doesnt tell you how it arrives at the 6. Whether it is 1d6/2 or 1d6 or 1d6*2, etc.
  2. There is a "repeat" damage message that has no obvious purpose. On the 2nd damage roll it shows the previous one, on the 3rd it shows the previous two, etc. It may actually serve a purpose. But we could not tell what it was exactly. We thought it might be an attempt at arriving at a cumulative number? Whatever it is doing, it is confusing how it is presented.
  3. He also mentioned under the burst fire heading that it appears to suggest having a "running total" of damage. We could not tell if that was happening or even needed to happen, but just wanted to point it out.

I can provide a save if needed, but but I dont have one directly related to these screenshots.
megamek.log
mekhq.log
Screenshot 2022-05-24 162324
Screenshot 2022-05-24 165825
Screenshot 2022-05-23 231123

@gsparks3
Copy link
Collaborator

gsparks3 commented May 25, 2022

(see page 216 in most recent Total Warfare printing under the "Burst-Fire Weapons" heading for the mention of a "running total" for BA burst-fire weapons against CI - wasn't sure if this was being implemented correctly or not given that the BA weapons are shown with individual damage reports per "shot")

@NickAragua
Copy link
Member

The multiple rows of "burst fire weapon against infantry" messages is probably just some kind of message accumulator that's not being reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI User Interface Reports Anything relating in game reporting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants