Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[49.10] Heat Buildup colors in weapons fire tab are off by one #4173

Closed
GiovanniBertuccio opened this issue Feb 12, 2023 · 0 comments · Fixed by #4191
Closed

[49.10] Heat Buildup colors in weapons fire tab are off by one #4173

GiovanniBertuccio opened this issue Feb 12, 2023 · 0 comments · Fixed by #4191
Labels
GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations Unit Display Deals with the in-game unit display window

Comments

@GiovanniBertuccio
Copy link

Environment

49.10, 49.11
Java Vendor: Eclipse Adoptium
Java Version: 11.0.14
Platform: Windows 10 10.0 (amd64)
System Locale: en_US
Total memory available to MegaMek: 2 GB

Description

The "Heat Buildup" text in the weapons tab changes colors at excess heat levels 0, 1-5, 6-8, 9-10, 11 (inclusive) and so on

I suspect it was meant to be 0, 1-4, 5-7, 8-9, 10.

The current levels change color 1 heat after a heat penalty is applied, e.g. the first color change is at 6 and should be at 5, when the -1 MP penalty is applied.

Files

heatchangescreenshot

An annotated screenshot is attached.
@kuronekochomusuke kuronekochomusuke mentioned this issue Feb 18, 2023
Merged
@kuronekochomusuke kuronekochomusuke added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI User Interface Unit Display Deals with the in-game unit display window labels Feb 18, 2023
HammerGS added a commit that referenced this issue Feb 21, 2023
@HammerGS
Merging the following.
f7560e5 
+ Issue #3603: Off Board Artillery with Deployment Delay Doesn't Display
Deployment Delay
+ Issue #3934: Deadfire LRM range brackets incorrect 0.49.10
+ Issue #4185: RFE: Visual GUI indicator that unit is using Searchlight.
+ Issue #4173: Heat Buildup colors in weapons fire tab are off by one
+ PR #4194: Show movement mode before move indicators
+ PR #4193: Show amount of heat over capacity on the weapon tab
HammerGS added a commit that referenced this issue Jun 9, 2024
@HammerGS
Committing PR's and Data for Megamek
89685d1 
+ PR #4178: Updated Family Modifier Logic, a Warring Faction Modifier, in Turnover and Retention Module
+ PR #4183: Fixed Multi-Person Original Unit Assignments in Personnel Market & Interactions with Turnover and Retention Module
+ PR #4173: Added Multiple Turnover and Retention Module Improvements
+ Fix #4182: Added Nag to Alert Users at Contract End fix
+ PR #4187: Restored Missing Code for Scenario Modifier Options & Campaign Option Layout Tweaks
+ PR #4188: Added Campaign Start Date Logging to Campaign
HammerGS added a commit that referenced this issue Jun 18, 2024
@HammerGS
Committing PR's and Data for Megamek
7ab7ce7 
+ PR #4178: Updated Family Modifier Logic, a Warring Faction Modifier, in Turnover and Retention Module
+ PR #4183: Fixed Multi-Person Original Unit Assignments in Personnel Market & Interactions with Turnover and Retention Module
+ PR #4173: Added Multiple Turnover and Retention Module Improvements
+ Fix #4182: Added Nag to Alert Users at Contract End fix
+ PR #4187: Restored Missing Code for Scenario Modifier Options & Campaign Option Layout Tweaks
+ PR #4188: Added Campaign Start Date Logging to Campaign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations Unit Display Deals with the in-game unit display window
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adjust heat color ranges kuronekochomusuke/megamek
2 participants
@GiovanniBertuccio @kuronekochomusuke