Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[49.18 Nightly] - Infantry Firing issue #5224

Closed
Thom293 opened this issue Mar 6, 2024 · 1 comment · Fixed by #5226
Closed

[49.18 Nightly] - Infantry Firing issue #5224

Thom293 opened this issue Mar 6, 2024 · 1 comment · Fixed by #5226
Assignees
@Sleet01
Labels
Bug

Comments

@Thom293
Copy link
Contributor

Thom293 commented Mar 6, 2024 •
edited
Loading

This was discussed in discord. Very quick bug report. Infantry (at least tested with Horse Cavalry AR and Laser versions) no longer fire their weapons. They will spot and do leg and swarm attacks, but not shoot their guns.

Sort of related: 4 of them were spotting one unit. Seems like there should be a "has been spotted" flag so multiple units dont waste their spot on a single target.
Screens showing them not firing, MHQ Save, Customs,

EDIT: Just to remind myself, I also need to post a UI and Turret not firing issue later.

image
image

Crazed Profanity30690614INFBUG.cpnx.gz
Mine.zip
@Sleet01 Sleet01 added the Bug label Mar 6, 2024
@Sleet01 Sleet01 self-assigned this Mar 6, 2024
@Thom293 Thom293 mentioned this issue Mar 6, 2024
Open
@Sleet01
Copy link
Collaborator

Sleet01 commented Mar 7, 2024

Ugh. This was me: the new ammo-selecting code was working correctly for infantry in the movement planning phase, where it guesses at possible attacks; it was also working correctly for ammo-fed weapons in the attack phase, which I tested heavily. But all infantry will skip actual infantry weapons during the attack phase because they don't think they have any ammo for the weapons.

Fix PR up soon.

@Sleet01 Sleet01 mentioned this issue Mar 7, 2024
Merged
HammerGS added a commit that referenced this issue Mar 13, 2024
@HammerGS
Merging following PR's
26c2fc2 
+ Fix #5214: Exception when loading saved game
+ Fix #5224: Infantry Firing issue
+ PR #5241: Add test to ensure every unit can load
+ PR #5244: Fixing MML #1452 Allows you to pod mount null signature
system.
IllianiCBT pushed a commit to IllianiCBT/megamek that referenced this issue Mar 18, 2024
@HammerGS @IllianiCBT
Merging following PR's
498a251 
+ Fix MegaMek#5214: Exception when loading saved game
+ Fix MegaMek#5224: Infantry Firing issue
+ PR MegaMek#5241: Add test to ensure every unit can load
+ PR MegaMek#5244: Fixing MML MegaMek#1452 Allows you to pod mount null signature
system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sleet01 Sleet01

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for infantry skipping non-ammo-fed infantry weapons during attack phase Sleet01/megamek
2 participants
@Sleet01 @Thom293