Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SV engine minimum weight #3898

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Fix SV engine minimum weight #3898

merged 1 commit into from
Sep 23, 2022

Conversation

neoancient
Copy link
Member

Minimum weight for a support vehicle fission or TL C fusion engine is 5 tons, not 0.5.

Fixes MegaMek/megameklab#910

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #3898 (448ffe2) into master (8870cb9) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3898      +/-   ##
============================================
- Coverage     23.59%   23.55%   -0.04%     
  Complexity     4810     4810              
============================================
  Files          2211     2212       +1     
  Lines        243194   243096      -98     
  Branches      45496    45496              
============================================
- Hits          57374    57265     -109     
- Misses       184361   184372      +11     
  Partials       1459     1459              
Impacted Files Coverage Δ
megamek/src/megamek/common/Engine.java 36.14% <0.00%> (ø)
megamek/src/megamek/common/Board.java 4.74% <0.00%> (-0.02%) ⬇️
...c/megamek/client/ui/swing/boardview/BoardView.java 0.62% <0.00%> (-0.01%) ⬇️
...k/src/megamek/client/ui/swing/minimap/Minimap.java 0.00% <0.00%> (ø)
...ient/ui/baseComponents/DefaultScrollablePanel.java 0.00% <0.00%> (ø)
megamek/src/megamek/common/AmmoType.java 98.83% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Windchild292 Windchild292 merged commit 9991d8c into master Sep 23, 2022
@Windchild292 Windchild292 deleted the sv_engine_weight branch September 23, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech C Fusion Engines do not obey minimum weight rule
2 participants