Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused firing modes from TAG #3910

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

NickAragua
Copy link
Member

Removes the firing modes that don't do anything from TAG type weapons; additionally, cleans up long-since unused code.

@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 23.55% // Head: 23.56% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a4aa958) compared to base (9991d8c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3910   +/-   ##
=========================================
  Coverage     23.55%   23.56%           
  Complexity     4810     4810           
=========================================
  Files          2212     2212           
  Lines        243072   243034   -38     
  Branches      45494    45481   -13     
=========================================
- Hits          57265    57264    -1     
+ Misses       184348   184311   -37     
  Partials       1459     1459           
Impacted Files Coverage Δ
megamek/src/megamek/common/TagInfo.java 0.00% <0.00%> (ø)
megamek/src/megamek/common/weapons/TAGHandler.java 0.00% <0.00%> (ø)
...amek/src/megamek/common/weapons/WeaponHandler.java 0.00% <0.00%> (ø)
...amek/src/megamek/common/weapons/tag/TAGWeapon.java 80.00% <ø> (-3.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2022

This pull request fixes 1 alert when merging a4aa958 into 9991d8c - view on LGTM.com

fixed alerts:

  • 1 for Useless comparison test

@NickAragua NickAragua merged commit d1db576 into MegaMek:master Sep 25, 2022
@NickAragua NickAragua deleted the remove_tag_modes branch September 25, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants