Account for extra slot taken up by large engine in conventional fighters #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers. Remove XXL slot considerations, as CFs cannot mount XXL engines per errata.
Codecov ReportBase: 23.56% // Head: 23.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3929 +/- ##
=========================================
Coverage 23.56% 23.56%
Complexity 4810 4810
=========================================
Files 2212 2212
Lines 243034 243032 -2
Branches 45481 45480 -1
=========================================
Hits 57264 57264
+ Misses 184311 184309 -2
Partials 1459 1459
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SJuliez
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MM currently accounts for extra slots for XXL engines, but not the extra slot for large engines. The XXL code is obsolete because CFs can no longer use XXL engines per errata.