Destroy Infantry field guns and artillery with trooper damage #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # megamek/src/megamek/client/ui/swing/UnitEditorDialog.java # megamek/src/megamek/common/MULParser.java
Codecov ReportBase: 23.56% // Head: 23.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3935 +/- ##
============================================
- Coverage 23.56% 23.56% -0.01%
Complexity 4810 4810
============================================
Files 2212 2212
Lines 243039 243049 +10
Branches 45484 45480 -4
============================================
- Hits 57264 57263 -1
- Misses 184316 184327 +11
Partials 1459 1459
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
While this is open I have a question. How does this affect the unit after it is imported back into HQ? MM sends back the crew with injuries and destroyed field guns. Will those guns need to be repaired, replaced, or just have the dead crew replaced to be functional? |
NickAragua
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO:AUE p.123 notes that field guns count as destroyed when they can no longer be crewed by the platoon. Despite the different rules text, I assume this extends to field arty. Per discussion with Hammer, the rules team says they're dead even for purposes of MHQ. Therefore with this PR field guns and arty get destroyed with trooper damage. As a result, some code that dealt with trooper damage and crew requirements is removed (FireControl and AttackAction).