Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AS Conversion Errata concerning PV calc #3992

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Nov 19, 2022

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 23.05% // Head: 23.04% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (09a4a40) compared to base (1c54ac8).
Patch coverage: 8.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3992      +/-   ##
============================================
- Coverage     23.05%   23.04%   -0.01%     
  Complexity     4813     4813              
============================================
  Files          2263     2263              
  Lines        248491   248517      +26     
  Branches      46189    46195       +6     
============================================
  Hits          57283    57283              
- Misses       189749   189775      +26     
  Partials       1459     1459              
Impacted Files Coverage Δ
megamek/src/megamek/client/ui/swing/ClientGUI.java 0.00% <0.00%> (ø)
...mek/src/megamek/client/ui/swing/CommonMenuBar.java 0.00% <0.00%> (ø)
...ek/src/megamek/client/ui/swing/GUIPreferences.java 34.09% <0.00%> (ø)
...src/megamek/client/ui/swing/MiniReportDisplay.java 0.00% <0.00%> (ø)
...egamek/client/ui/swing/unitDisplay/ExtraPanel.java 0.00% <0.00%> (ø)
.../alphaStrike/conversion/ASPointValueConverter.java 0.00% <0.00%> (ø)
...on/weapons/prototypes/ISERLaserLargePrototype.java 78.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SJuliez SJuliez merged commit 27d232d into MegaMek:master Nov 26, 2022
@SJuliez SJuliez deleted the AS_errata branch January 6, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants