Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow split weapons between CT and H locations #4007

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Nov 25, 2022

This allows split weapons between the H and CT locations of Meks when loading them from an mtf file. Used for MML Issue #1197 (this PR is not dependent on anything).

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 23.05% // Head: 23.05% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (393d97e) compared to base (c9c3ba6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4007      +/-   ##
============================================
- Coverage     23.05%   23.05%   -0.01%     
  Complexity     4813     4813              
============================================
  Files          2263     2263              
  Lines        248513   248514       +1     
  Branches      46194    46195       +1     
============================================
  Hits          57283    57283              
- Misses       189771   189772       +1     
  Partials       1459     1459              
Impacted Files Coverage Δ
megamek/src/megamek/common/loaders/MtfFile.java 46.87% <0.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gotta ask, what unit prompted this?

@HammerGS
Copy link
Member

Was a discussion on the Discord. Led the to clarifying question to CGL.

@SJuliez SJuliez merged commit 4410f90 into MegaMek:master Nov 26, 2022
@SJuliez SJuliez deleted the WeaponSplitCT_H branch January 6, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants