Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report keywords managed in client settings #4039

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

kuronekochomusuke
Copy link
Collaborator

#4035

manage report keywords in client settings for the Mni Report Dialog

can add and remove keywords

image

image

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 22.99% // Head: 22.99% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (03402de) compared to base (3ff6324).
Patch coverage: 5.00% of modified lines in pull request are covered.

❗ Current head 03402de differs from pull request most recent head 55058fc. Consider uploading reports for the commit 55058fc to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4039      +/-   ##
============================================
- Coverage     22.99%   22.99%   -0.01%     
  Complexity     4813     4813              
============================================
  Files          2263     2263              
  Lines        249050   249065      +15     
  Branches      46251    46253       +2     
============================================
+ Hits          57280    57281       +1     
- Misses       190311   190325      +14     
  Partials       1459     1459              
Impacted Files Coverage Δ
.../megamek/client/ui/swing/CommonSettingsDialog.java 0.00% <0.00%> (ø)
...src/megamek/client/ui/swing/MiniReportDisplay.java 0.00% <0.00%> (ø)
...c/megamek/common/preference/ClientPreferences.java 31.61% <25.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HammerGS
Copy link
Member

This is great! Thanks for looking into it.

@SJuliez SJuliez merged commit cba7deb into MegaMek:master Dec 14, 2022
@kuronekochomusuke kuronekochomusuke deleted the RFE4035 branch December 16, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants