Issue #2652 TacOps BA crits #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SJuliez
added
Errata
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * | ||
| * @param isAttackingConvInfantry Set to true when attacked by CI, as these cannot score TacOps crits | ||
| */ | ||
| public HitData rollHitLocation(int table, int side, int aimedLocation, AimingMode aimingMode, |
Check notice
Code scanning / CodeQL
Useless parameter
| * @param isAttackingConvInfantry Set to true when attacked by CI, as these cannot score TacOps crits | ||
| */ | ||
| public HitData rollHitLocation(int table, int side, int aimedLocation, AimingMode aimingMode, | ||
| int cover, boolean isAttackingConvInfantry) { |
Check notice
Code scanning / CodeQL
Useless parameter
Comment on lines
600
to
601
| public HitData rollHitLocation(int table, int side, int aimedLocation, AimingMode aimingMode, | ||
| int cover, boolean isAttackingConvInfantry) { |
There was a problem hiding this comment.
Why add this method with two unused parameters? Keeping it consistent with the general rollHitLocation methods?
There was a problem hiding this comment.
More like, didn't think about it. I guess it's not worth getting the compiler warnings and github alerts for it, so I removed them.
Windchild292
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2652
It might make sense not to merge this right before a release.