Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some gui scale issues #4055

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

kuronekochomusuke
Copy link
Collaborator

  • increase the width of the fovHighlightRingsRadii in client setting, so that it can handle large gui scales
  • update keyboard shortcut overlay so that it processes any preference changes
  • clean up code in planetary conditions overlay code, so it is more similar to the code in keyboard shortcut overlay

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 23.00% // Head: 23.00% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f82695a) compared to base (a5ee353).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4055      +/-   ##
============================================
- Coverage     23.00%   23.00%   -0.01%     
  Complexity     4813     4813              
============================================
  Files          2264     2264              
  Lines        249502   249505       +3     
  Branches      46325    46325              
============================================
  Hits          57398    57398              
- Misses       190645   190648       +3     
  Partials       1459     1459              
Impacted Files Coverage Δ
.../megamek/client/ui/swing/CommonSettingsDialog.java 0.00% <0.00%> (ø)
.../client/ui/swing/boardview/KeyBindingsOverlay.java 0.00% <0.00%> (ø)
...ui/swing/boardview/PlanetaryConditionsOverlay.java 0.00% <0.00%> (ø)
...gamek/src/megamek/client/ratgenerator/Ruleset.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Windchild292 Windchild292 added Refactoring For New Dev Cycle This PR should be merged at the beginning of a dev cycle labels Dec 17, 2022
@kuronekochomusuke kuronekochomusuke added Bug GUI User Interface labels Dec 17, 2022
@HammerGS
Copy link
Member

Should we include this in 49.11 since it already has a lot of GUI stuff and this seems to fix/improve those.

@kuronekochomusuke
Copy link
Collaborator Author

they are kind of minor, and you can work around them. but it would be a nicer experience to have them.

@Windchild292 Windchild292 removed the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Dec 17, 2022
@Windchild292 Windchild292 merged commit 9b7ffc5 into MegaMek:master Dec 17, 2022
@kuronekochomusuke kuronekochomusuke deleted the guiScaleIssues branch December 20, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants