Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow report display split pane to resize #4057

Merged

Conversation

kuronekochomusuke
Copy link
Collaborator

when you have 2 rows of report phases in the report display it cause the resize of the split pane to freeze. so the pilot display and chat log are hard to see. only a few lines visible.

this allows it to resize in this case.

image

@kuronekochomusuke kuronekochomusuke added Bug GUI User Interface labels Dec 17, 2022
Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spacing issue, otherwise looks good

megamek/src/megamek/client/ui/swing/ReportDisplay.java Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 23.00% // Head: 23.00% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (975c2a0) compared to base (8c2bcdc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4057      +/-   ##
============================================
- Coverage     23.00%   23.00%   -0.01%     
  Complexity     4813     4813              
============================================
  Files          2264     2264              
  Lines        249502   249504       +2     
  Branches      46325    46325              
============================================
  Hits          57398    57398              
- Misses       190645   190647       +2     
  Partials       1459     1459              
Impacted Files Coverage Δ
...mek/src/megamek/client/ui/swing/ReportDisplay.java 0.00% <0.00%> (ø)
...gamek/src/megamek/client/ratgenerator/Ruleset.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
@Windchild292 Windchild292 merged commit fada42c into MegaMek:master Dec 17, 2022
@kuronekochomusuke kuronekochomusuke deleted the reportDisplayResizeIssue branch December 20, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants