Modernizing Team #4106
Merged
Modernizing Team #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 22.95% // Head: 22.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4106 +/- ##
=========================================
Coverage 22.95% 22.96%
- Complexity 4817 4822 +5
=========================================
Files 2282 2276 -6
Lines 250311 250219 -92
Branches 46367 46348 -19
=========================================
+ Hits 57462 57464 +2
+ Misses 191398 191303 -95
- Partials 1451 1452 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -202,7 +202,7 @@ public void updateTable(Game game) { | |||
| int hiddenBv = 0; | |||
| boolean[] unitCritical = { false, false, false, false, false }; | |||
| boolean[] unitWarnings = { false, false, false, false, false }; | |||
| for (Player teamMember: team.getPlayersVector()) { | |||
| for (Player teamMember: team.players()) { | |||
There was a problem hiding this comment.
Suggested change
| for (Player teamMember: team.players()) { | |
| for (Player teamMember : team.players()) { | |
megamek/src/megamek/common/Team.java
Outdated
| if (ObserverTeam == null) { | ||
| cacheObserverStatus(); | ||
| /** Adds the given player to this team. */ | ||
| public void addPlayer(Player player) { |
# Conflicts: # megamek/src/megamek/common/Team.java
|
Done. |
Windchild292
approved these changes
Jan 15, 2023
HammerGS
added a commit
to SJuliez/megamek
that referenced
this pull request
May 25, 2024
MegaMek + Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively MegaMekLab + Fix #MegaMek#1514: Fix Atrocious table shading render speed MekHQ + PR MegaMek#4106: Use tabs in customize scenario dialog + PR MegaMek#4105: Updated Post-Scenario Logging for Prisoners + PR MegaMek#4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards + PR MegaMek#4102: Fixed Award Tier Count Calculations in PersonViewPanel + PR MegaMek#4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel + PR MegaMek#4054: Added Life Paths Campaign Options Tab, Added Education Module Very Important to read the documentation on this feature (See Docs folder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of Team which was full of outdated code. Changes in other classes are due to renames or removing Enumerations.
There are two
// TODO: remove from Team
in there. I'll remove this in other PRs that are already part-finished.