Making Supercooled Myomer operational #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 23.00% // Head: 22.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4111 +/- ##
============================================
- Coverage 23.00% 22.95% -0.05%
- Complexity 4813 4819 +6
============================================
Files 2264 2282 +18
Lines 249505 250311 +806
Branches 46325 46372 +47
============================================
+ Hits 57398 57460 +62
- Misses 190648 191399 +751
+ Partials 1459 1452 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Windchild292
approved these changes
Jan 14, 2023
Comment on lines
1166
to
1167
| } | ||
| if (nhits < hits) { |
There was a problem hiding this comment.
Suggested change
| } | |
| if (nhits < hits) { | |
| } | |
| if (nhits < hits) { |
| } | ||
|
|
||
| /** | ||
| * @return the heat generated while the mech is walking. | ||
| */ | ||
| public int getWalkHeat(Entity e) { | ||
| boolean hasSCM = ((e instanceof Mech) && ((Mech) e).hasWorkingSCM()); |
There was a problem hiding this comment.
Suggested change
| boolean hasSCM = ((e instanceof Mech) && ((Mech) e).hasWorkingSCM()); | |
| boolean hasSCM = (e instanceof Mech) && ((Mech) e).hasWorkingSCM(); |
| } | ||
| } | ||
|
|
||
| /** | ||
| * @return the heat generated while the mech is running. | ||
| */ | ||
| public int getRunHeat(Entity e) { | ||
| boolean hasSCM = ((e instanceof Mech) && ((Mech) e).hasWorkingSCM()); |
There was a problem hiding this comment.
Suggested change
| boolean hasSCM = ((e instanceof Mech) && ((Mech) e).hasWorkingSCM()); | |
| boolean hasSCM = (e instanceof Mech) && ((Mech) e).hasWorkingSCM(); |
| } | ||
| } | ||
|
|
||
| /** | ||
| * @return the heat generated while the mech is sprinting. | ||
| */ | ||
| public int getSprintHeat() { | ||
| public int getSprintHeat(Entity e) { | ||
| boolean hasSCM = ((e instanceof Mech) && ((Mech) e).hasWorkingSCM()); |
There was a problem hiding this comment.
Suggested change
| boolean hasSCM = ((e instanceof Mech) && ((Mech) e).hasWorkingSCM()); | |
| boolean hasSCM = (e instanceof Mech) && ((Mech) e).hasWorkingSCM(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says; SCM was construction-only so far. A difficulty is that SCM is not destroyed upon the first crit which it shares with Partial Wings and Mek shields. There are probably issues with damage to shields and PW which I haven't tried to solve here.
Sadly, there's 0 canon units using SCM.