Add more target info to the WeaponsPanel of the Unit Display #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
HammerGS
added
the
In Development (Draft)
added 8 commits
May 20, 2023 15:26
pakfront
added
(RFE) Enhancement
SJuliez
approved these changes
Jun 7, 2023
|
There are conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a section with current target info to the Weapon Panel. It is separated by a split pane to allow user to adjust details they need to see. This is a major refactoring of the WeaponPanel class to make it simpler to debug individual components, and share layout settings between components. This should help with any further work needed on panel.
There is a known issue with the WeaponPanel hanging on to old target data between rounds. Apparently this has been the case even before this PR. I plan on addressing this and some other issues in my next PR, which will require a refactor I'd rather keep out of this PR.