Map generator upgrades #4514
Merged
Map generator upgrades #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SJuliez
approved these changes
Jun 10, 2023
| @@ -769,6 +844,10 @@ public static void makeCompactGrid(Container parent, | |||
| y = Spring.sum(y, Spring.sum(height, Spring.constant(yPad))); | |||
| } | |||
|
|
|||
| // for some reason the bottom border runs over the bottom textboxes in | |||
| // some of these, so we add an experimentally established padding to the bottom | |||
| y = Spring.sum(y, Spring.constant(13)); | |||
There was a problem hiding this comment.
The reason is the call to adjustDialog to adapt it to the gui scale, which doesn't relayout the dialog. I've fought with this too and can't say I won. A slightly less hacky way to deal with it is to add a pack() in RandomMapDialog after l.476, directly after the call to adaptToGUIScale().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a large pull request, but it adds a lot of stuff to the random map generator.
-Tundra
-Ultra Rough
-Ultra Rubble (and greater regular rubble variety)
-Ultra Woods
-Jungle (standard/heavy/ultra)