-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamemaster mode can edit unit during game #4576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
I think this may have some unintended effects if the unit has been damaged; we'll want to test around that, especially things like blown-off limbs, ammo explosions and crew effects.
I wonder how this would work with units being carried on other units, like mechanized BA, infantry in APCs, or dropships docked with jumpships... |
This is expected with the current PR. I think this is useful enough that we could put it in as in. We should create new PR to handle the effects, as it's fairly complex. For example, currently if you edit the damage:
|
I added the Configure/CustomMech dialog as well. Lots of cool stuff you can do with it mid-game as GM such as change pilot names (surprise, it's Natasha!), unhide Princess units, hide units mid-game (not legal, I know, but great for RP) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine code-wise.
I don't think we need to trigger ammo explosions or anything else that comes as the effect of doing "normal" damage, but damaged sections will definitely need to be disabled - or we can prevent setting the structure below 1.
This allows a player with the Gamemaster (GM) role to use the right click menu to:
To do this, the player will have to become a Gamemaster by
FYI adding support for editing pilot health, buildings and hexes will take a bit more work but is possible in another PR