Quirks misc code changes #4944
Merged
Quirks misc code changes #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /** | ||
| * Sets the value | ||
| * | ||
| * @param value value to set | ||
| */ | ||
| public abstract void setValue(Object value); | ||
| void setValue(Object value); |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
There was a problem hiding this comment.
legacy issue. Seems no problem at this moment. I tried, can't just remove it.
|
I've been testing the Quirks branch's and everything seems to work. But I haven't tested a unit with every quirk. |
NickAragua
reviewed
Dec 12, 2023
|
Hehe I gave myself some conflicts :) |
# Conflicts: # megamek/src/megamek/common/options/Quirks.java
NickAragua
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at allowing Quirk editing in MML, so I really needed some API improvements for Quirks and WeaponQuirks. Also updates and condenses the Quirks validity checks.
In the MechSummary, the weapon quirks list now shows the weapon location. In the weapon list, weapons with quirks get a (Q) marker.