-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit shadow #5188
Unit shadow #5188
Conversation
Should I be planning to switch the sprites back to the original unshaded versions? |
ground units yes. |
Another thought on this, I know in the past I've seen comments that players don't like shadow effects. With the move back to original sprites, should this be made an option? Defaulted to on. |
Yes I can add that. I could make the unit shadows depend on the terrain shadow setting to avoid yet another checkbox |
I think that would be a great idea, but I would set the option to on by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Do we want to have this as an option for people using potato computers? Some of the computations in EntityImage look a little gnarly and may be not great for performance?
edit: lol looks like Hammer had a similar idea.
Yes, it's now tied to the terrain shadows. Actually, the icons are cached and during a game (after the lobby) I found it difficult to get them to do the EntityImage thing at all. But in the lobby, they constantly redraw so I guess, better that way. |
Hey - I just used this for the first time. Looks really damn good. Thank you. |
This adds a programmatic drop shadow to icons when not airborne. This is meant to replace the static shadow we have around many icons. The drop shadow reflects a unit's height and is oriented like the terrain shadows.