Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full chassis in the OfficialUnitList.txt #5201

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Feb 24, 2024

Writes the full chassis to the OfficialUnitList.txt to fix the check for canon units which compares based on entity.getShortNameRaw() which includes the full chassis, e.g. Mad Cat (Timber Wolf)

Fixes #5191

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SJuliez SJuliez merged commit d8fa093 into MegaMek:master Feb 26, 2024
4 checks passed
@SJuliez SJuliez deleted the clanname-canon branch March 9, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[49.18] Canon units excluded from 'Canon Units Only' setting
2 participants