EntityImage: Handle unknown elevation exceptions #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoancient
approved these changes
Mar 7, 2024
NickAragua
requested changes
Mar 8, 2024
| unitElevation = entity.getElevation(); | ||
| int elevation = 0; | ||
| try { | ||
| elevation = entity.getElevation(); |
There was a problem hiding this comment.
Do we really want to use exceptions for flow control here?
There was a problem hiding this comment.
Doesn't look like the place for an exception. This was old code in Entity. I removed the exception. One could add a hasElevation or knowsElevation method or something but that's a bit beyond this PR.
|
Merging as review requests completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity.getElevation throws an exception when the unit has no elevation (e.g. offboard).
Fixes #5214