Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks for enemy hidden units #5236

Merged
merged 4 commits into from
Mar 13, 2024
Merged

checks for enemy hidden units #5236

merged 4 commits into from
Mar 13, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Mar 9, 2024 •
edited
Loading

  • during tag phase, hide to-hit / distance sprites for enemy hidden units
  • in force display hide unit information for enemy hidden units

fixes #5228

Sleet01
Sleet01 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice and compact.

@SJuliez SJuliez merged commit 068664f into MegaMek:master Mar 13, 2024
4 checks passed
@kuronekochomusuke kuronekochomusuke deleted the hiddenFixes branch April 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[49.18] TAG phase unintentionally reveals hidden unit locations
3 participants
@kuronekochomusuke @Sleet01 @SJuliez