Fix null pointer when turning with shortcut keys in movement phase. #5351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5350
During the movement phase that follows a previous firing phase - when using the short cut keys "Shift-A" or "Shift-D to turn left or right results in a null pointer exception in the
FiringDisplay
class when it is checking for torso twist left or right.The expression was updated to promote the check for firing display visibility and ignore event status BEFORE checking the selected entity which can be null in the
FiringDisplay
during the movement phase.This bug could also cause a null pointer when trying to turn other units - not just aerospace fighters like the bug report suggests.