FIX: NPE when attacking a unit on a building when Blood Stalking another unit. #5354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5275
When targeting a mech on a building, a choice dialog is created that calculates some to-hit metrics for each of the targets in the selected hex for the user to choose. However, when the attacker has the Blood Stalker SPA with a declared target, this ends up trying to compare the building to see if it's the chosen target in which case the
targetvalue passed to the to-hit calculation logic is passed as null.This fix checks to see if
targetis null before callingtarget.getID().