-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements #5261: Simple rotating per-round save file system. #5359
Conversation
Based on comments from the QA team, I would like to strongly advocate for including this functionality in the .19 release in order to facilitate better testing results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed the code - looks good.
Can you test this with:
|
I can test this in about 10 hours if no one gets to it first. |
I have some errands to run this morning, but hopefully will knock the extra testing out after lunch. |
@HoneySkull @Thom293 Tested and confirmed:
Given that, I'm going to pull this. |
This patch adds user-configurable per-round rotating save files, based on the system used by MekHQ, to MegaMek.
These saves are separate from the other autosaves and default to 3, so the last 3 rounds of the most recent game will be saved. Critically, these save files will not be overwritten by starting MegaMek; a game must actually be entered and the start of a new round must occur for this save system to be triggered.
File name format is "Round-<current round#>-autosave_.sav.gz", e.g.
Round-3-autosave_2024-04-13_03-37-08.sav.gz
. Note that this means only 3 rotating save files total will be saved, not 3 per separate game. If we want that functionality, more work is required.Testing:
Close #5261