Implement RFE #5408: update Princess ammo conservation values to make… #5415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…to make Princess more aggressive Updated type of ammoConservation Map
Missed a find/replace
Combine prior changes and new classes in unit tests
Sleet01
force-pushed
the
RFE_5408_adjust_ammo_conservation_to_hit_thresholds
branch
from
fca01dc to
8c0ecde
Compare
SJuliez
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Princess more aggressive
After a few reports that Princess was being too withholding of her ammo-based love, we did some analysis and determined that the current ammo conservation thresholds should be bumped up significantly.
Edit: also adds separate, simpler calculations for one-shot weapons, which previously were handled like normal weapons having only a single round of ammo remaining. We want to incentivize firing these weapons slightly earlier so the new code pushes allowed to-hit % down slightly for each level of Aggression.
Testing:
Close #5408